Remove abstract marker on get_train_test_datasets

timokau commented 4 years ago

Description

There is a default method implementation, so there is no reason to mark it abstract. The marker makes it impossible to instantiate ChoiceDatasetGenerator, which does not explicitly override the default implementation.

Fixes #166

How Has This Been Tested?

Testsuite & lints.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.

timokau commented 4 years ago

Travis has a flaky issue (potery says "Connection reset by peer"), but the tests pass locally.

kiudee commented 4 years ago

Yes, I had that happen as well on other repositories. I will rerun the jobs until they pass.

timokau commented 4 years ago

Had to do a trivial rebase since GitHub didn't allow me to merge. No changes. Please re-approve.

kiudee / cs-ranking