search

kiuliani / geoda

Automatically exported from code.google.com/p/geoda
GNU General Public License v3.0
0 stars 0 forks source link

Save with unsaved changes warning when everything is saved #96

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
In GeoDa 1.5.27

1) Open a project file
2) Make a change that results in a save to the .gda file such as grouping two 
columns
3) Save changes
4) Try to close project, but notice that there is a warning about unsaved 
changes.

Original issue reported on code.google.com by mmcc...@gmail.com on 19 Feb 2014 at 9:48

GoogleCodeExporter commented 8 years ago 
Update: GdaFrame::OnSaveProject is automatically saving Meta Data and 
datasource every time.  This is contrary to our intended design: datasource 
data should only be saved when actual changes are need, not when only metadata 
has changed such as for creating a new group.

Please test on columbus.gda in Examples.  Try creating a new space-time group 
on two variables and then press save to see bad behavior.

Original comment by mmcc...@gmail.com on 25 Feb 2014 at 3:21

GoogleCodeExporter commented 8 years ago 
Fixed in ci 3073.

Caused by inappropriate SetChangedSinceLastSave(true); in gda file related 
operations e.g. Group/Ungroup  in DbfTable as well as OGRTable.

Original comment by lixun...@gmail.com on 25 Feb 2014 at 6:18