kiva / protocol-common

Shared code across the various protocol microservices
Apache License 2.0
10 stars 3 forks source link

PRO-2696: Update error codes #26

Closed ghost closed 3 years ago

ghost commented 3 years ago

Signed-off-by: Jeff Kennedy jeffk@kiva.org

🔥 🐞 🙋 🚫 🚀

(Click here if you don't understand these emojis)

What issue is this targeting?

Changes proposed in this pull request Almost none of the error codes that are returned by Identity Service are currently represented in protocol-common, which means that other services that need to interact with Identity Service may more easily end up out of sync with the API contract. Increments the version of protocol-common so that you have to pull the latest to actually get these. This is also because it fixes a typo in the naming of one of the error codes.

After this is deployed, I'll follow up with updates to all the various services to use this new version and make sure they access error codes in a uniform manner. Corresponding update to Identity Service is here: https://github.com/kiva/guardian-bio-auth/pull/15

🚀 Deployment changes 🚀
(list added or removed env, db changes etc)

Other Notes