kiva / protocol-common

Shared code across the various protocol microservices
Apache License 2.0
10 stars 3 forks source link

PRO-2868: Add a decorator to allow a class or method to not be auto-logged #28

Closed ghost closed 3 years ago

ghost commented 3 years ago
🔥 🐞 🙋 🚫 🚀

(Click here if you don't understand these emojis)

What issue is this targeting?

Changes proposed in this pull request

🚀 Deployment changes 🚀
(list added or removed env, db changes etc)

Other Notes

Signed-off-by: Jeff Kennedy jeffk@kiva.org

voutasaurus commented 3 years ago

Maybe this is just my ignorance at how decorators work, did you consider adding an example / docs of how to use this decorator?

ghost commented 3 years ago

Maybe this is just my ignorance at how decorators work, did you consider adding an example / docs of how to use this decorator?

Good call. I was thinking that an example in a working service would be good enough, but it's much better to include an example here.