search

kiva / protocol-common

Shared code across the various protocol microservices
Apache License 2.0
10 stars 3 forks source link

run ci tests for node16 in preparation for upgrade #71

Closed voutasaurus closed 2 years ago

voutasaurus commented 2 years ago

Signed-off-by: Anthony Voutas anthonyv@kiva.org

🔥 🐞 🙋 🚫 🚀

(Click here if you don't understand these emojis)

What issue is this targeting? Upgrading to node16 (https://github.com/kiva/protocol-architecture/issues/5)

Changes proposed in this pull request Run common library tests in node16 to ensure that service upgrades are smooth with regards to this library

🚀 Deployment changes 🚀
(list added or removed env, db changes etc)

Other Notes Another PR will be required once all the services are upgraded to node16 to actually deploy this library using node16. I just figured it's safer to keep deploying it as a node14 library until everything else is upgraded. Somebody can correct me if I'm wrong about that

ghost commented 2 years ago

My take is that there's no need to update the package.json version because there's no changes to update. The value of this change is that any changes made to protocol-common while we're upgrading other services will. be verified against both node 14 and node 16. Maybe unnecessary, but certainly doesn't hurt.

matt-raffel-kiva commented 2 years ago

@jeffk-kiva my thoughts exactly on why the package version should be updated--catches any downstream gotchas now not later.

But as you stated, there shouldnt be any changes--cautionary since we are changing the underlying runtime environment.

As I said, I can go either way.

matt-raffel-kiva commented 2 years ago

I talked with @voutasaurus . I understand now.