kiva / protocol-common

Shared code across the various protocol microservices
Apache License 2.0
10 stars 3 forks source link

Publish Protocol-Common as an ESM library #76

Closed ghost closed 2 years ago

ghost commented 2 years ago

Resolves #52 Resolves #69

Summary of Changes:

Has been tested locally using npm link against protocol-aries and aries-key-guardian. This version should still be considered experimental as it has not yet been fully tested against components that have protocol-aries as a dependency.

Still TODO is to update documentation on how to use this. This has been held off on until these changes can be considered as no longer experimental.

ghost commented 2 years ago

I wish there was a way to get rid of the .js on import statements.

I'm totally with you on this. There is a way to get rid of it, but it involves an experimental flag which may not be supported in the future, so the most forward-looking approach is just to include the .js.