voutasaurus
commented
4 years ago Code looks good! There is an annoying task though to go through all the k8s secrets and compare to what's in the configs, and delete any "secret" that's really a config - before we deploy to each env
@jsaur Is this captured in a ticket or should I make one now?
Signed-off-by: Matt Raffel mattr@kiva.org
(Click here if you don't understand these emojis)
What issue is this targeting? PRO-2329
Changes proposed in this pull request do not set env from env.json if it already exists
🚀 Deployment changes 🚀
We will want to be careful that k8s secrets do not have values that are wrong but correct in the env.json files as the env.json values will no longer be applied when they exist in secrets (or as preexisting env)
Other Notes