kivikakk / comrak

CommonMark + GFM compatible Markdown parser and renderer
Other
1.17k stars 140 forks source link

[skip test] Release v0.23.0 #405

Closed github-actions[bot] closed 4 months ago

github-actions[bot] commented 4 months ago

This is an automated PR to build the latest changelog. Upon merging, a new release will be created and published to crates.io.
Due to security considerations, PRs created by GitHub Actions cannot be merged automatically. Please review the changes and merge the PR.
If you require the test suites to run, you can close the PR and reopen it to trigger those workflows.

kivikakk commented 4 months ago

lol, okay. Closing #404 triggered this, just as closing #395 triggered that.

gjtorikian commented 4 months ago

That's super weird; this PR should only open on a manual workflow dispatch 🤔 Is this more trouble than it's worth?

kivikakk commented 4 months ago

I had a noodle and suddenly realised: do we need an if: on the prepare job too? We do the workflow on closed PRs …

https://github.com/kivikakk/comrak/blob/9962cdf3ffb49d98cf62a3d03a224b8903cad165/.github/workflows/release.yml#L5-L7

…

but we don't have any condition on prepare, which is what creates the PR:

https://github.com/kivikakk/comrak/blob/9962cdf3ffb49d98cf62a3d03a224b8903cad165/.github/workflows/release.yml#L13-L25

vs.

https://github.com/kivikakk/comrak/blob/9962cdf3ffb49d98cf62a3d03a224b8903cad165/.github/workflows/release.yml#L97-L104

kivikakk commented 4 months ago

I'll try pushing a condition direct to main, then close this to see if we get a new one.

kivikakk commented 4 months ago

Success — no new PR.

digitalmoksha commented 4 months ago

Nice!