search

kivikakk / koino

CommonMark + GFM compatible Markdown parser and renderer
https://hrzn.ee/kivikakk/koino
MIT License
118 stars 13 forks source link

Add Zigmod support #38

Closed nektro closed 2 years ago

nektro commented 2 years ago

it now supports all of koino's platforms

nektro commented 2 years ago

not sure why only macos is failing. seems to not like where the header files are

https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/pcre.rb

kivikakk commented 2 years ago

Yep, homebrew's a bit of a nuisance. Looking into it.

kivikakk commented 2 years ago

Hm, alright, turns out I don't have the time to look into this today. It's odd because libpcre itself builds with zigmod fine, so unclear what the issue is with including it as a dependency. Adding - src: system_lib pcre to koino's zig.mod does not help.

nektro commented 2 years ago

my only guess is it needs the name to be libpcre and doesn't understand pcre (since that's the name you use in libpcre.zig's build.zig)

not sure if that's pkg-config or pcre or homebrew's fault

nektro commented 2 years ago

maybe linux working was a fluke

[nix-shell:~/other/gh/koino]$ pkg-config --cflags pcre
Package pcre was not found in the pkg-config search path.
Perhaps you should add the directory containing `pcre.pc'
to the PKG_CONFIG_PATH environment variable
No package 'pcre' found

[nix-shell:~/other/gh/koino]$ pkg-config --cflags libpcre
-I/nix/store/hyn9wa71pcicvnjxik2ryb0rvay765mm-pcre-8.44-dev/include

will revert part of the change i made in libpcre.zig

kivikakk commented 2 years ago

CI failure is because it looks like the Actions node got rate limited by GitHub … 🤦‍♀️ Retrying.

kivikakk commented 2 years ago

Success :) Thank you!! <3