search

kivy / kivy-ios

Toolchain for compiling Python / Kivy / other libraries for iOS
https://kivy.org/docs/guide/packaging-ios.html
MIT License
758 stars 237 forks source link

Fix for upstream issues with compiler path #866

Closed tcaduser closed 9 months ago

tcaduser commented 9 months ago

This is a fix for issue #860. While I agree that it should be fixed upstream, they have not done so in a year.

misl6 commented 9 months ago

Hi @tcaduser and @AndreMiras, how about applying the patches from https://github.com/python/cpython/pull/96399 instead?

AndreMiras commented 9 months ago

Hi @tcaduser and @AndreMiras, how about applying the patches from python/cpython#96399 instead?

Yes I thought it would be cleaner to patch cpython, but I assumed it would be a lot harder as I didn't realized it already existed. If patching the different versions is easy enough then yes we could go down that route

tcaduser commented 9 months ago

Hi @misl6, @AndreMiras,

I just reviewed the upstream patch. It will still do the wrong thing for my original case:

/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/tmpyicccjzp

Their patch is to perform a wildcard search for icc only on the filename, and not the full path.

image

Please let me know if you still want my fix and I'll incorporate the suggested changes.

misl6 commented 9 months ago

Thanks for addressing the comments and thanks for reviewing the upstream patch. Maybe you could share them that valuable feedback. PR is good for a merge to me, but I leave @misl6 having the final word for it.

Ok, let's merge it while they sort it out on their side. 👍 Thank you @tcaduser and @AndreMiras.