`DDSFile.save` raise a type error by invalid write - Githubissues

kivy / kivy

Open source UI framework written in Python, running on Windows, Linux, macOS, Android and iOS

https://kivy.org

MIT License

17k stars 3.04k forks source link

`DDSFile.save` raise a type error by invalid write #8675

Closed marinelay closed 4 weeks ago

marinelay commented 1 month ago

Software Versions

Python: 3.9.18
OS: Ubuntu 22.04
Kivy: 2.3.0
Kivy installation method: pip install

Describe the bug

https://github.com/kivy/kivy/blob/c0d4894384abb81cf4729984a1eaa4c437d266da/kivy/lib/ddsfile.py#L312-L314

At line 313, writing string is not allowed because the file is opened as binary format. It should be fixed to b'DDS '.

Thank you.

Code and Logs and screenshots https://github.com/kivy/kivy/blob/c0d4894384abb81cf4729984a1eaa4c437d266da/kivy/lib/ddsfile.py#L312-L314

marinelay commented 4 weeks ago

Oh, I just now saw the comment Kivy does not provide any support for it. I'm sorry to report false alarm.