kivy / kivy

Open source UI framework written in Python, running on Windows, Linux, macOS, Android and iOS
https://kivy.org
MIT License
17k stars 3.04k forks source link

Sphinx/docs: Avoid usage of deprecated `style` keyword #8709

Closed kbaikov closed 1 week ago

kbaikov commented 2 weeks ago

Fixes: https://github.com/kivy/kivy/issues/8230

Style keyword is deprecated in sphinx 7.x

Maintainer merge checklist

welcome[bot] commented 2 weeks ago

Thanks for opening your first pull request here! 💖 Please check out our contributing guidelines.

kbaikov commented 2 weeks ago

Hi @misl6

Thank you for a quick reply. So my thinking was to install sphinx version 7.x and try to build kivy documentation with a simple make target. make html or make -C doc html This is the minimal fix that makes the docs to build.

Perhaps i am missing something else. Please direct me. Thanks!

misl6 commented 1 week ago

So my thinking was to install sphinx version 7.x and try to build kivy documentation with a simple make target. Yep, that build is also performed by our CI/CD pipeline, and we can configure to do that with sphinx 7.x.x.

Did you checked https://github.com/sphinx-doc/sphinx/pull/11381/files ? It looks like to me we actually need to support more stylesheets, and definitely we do not need to change style to styles in this HTML tag.

kbaikov commented 1 week ago

@misl6 Indeed, thank you. Please take a look at the latest change. This builds in the latest sphinx and leaves the HTML tag alone.

kbaikov commented 1 week ago

Fixed a typo.

welcome[bot] commented 1 week ago

Congrats on merging your first pull request! 🎉🎉🎉