Initialized missing variables, added new test for server sending on different port

kivy / oscpy

An efficient OSC implementation compatible with python2.7 and 3.5+

MIT License

109 stars 27 forks source link

Initialized missing variables, added new test for server sending on different port #45

Closed Heideachim closed 5 years ago

Heideachim commented 5 years ago

In the 'client' example, variables 'address' and 'port' where misssing. Initialized. Additionally, added two missing '*' in functions args. Most of all, there is a new test: If a server sends something on a port different than its listening port, this might crash the listening thread on Windows machines. This now is checked.

tshirtman commented 5 years ago

Was merged after cleanup, but as you can see, the tests do pass on windows as well as osx and linux, i guess i'll have to reboot on windows to try here.

edit: indeed, it happens on my machine as well in windows, just not in the CI. how nice… opened as bug #48