search

kivy / plyer

Plyer is a platform-independent Python wrapper for platform-dependent APIs
https://plyer.readthedocs.io
MIT License
1.61k stars 427 forks source link

Keystore now encrypts data before storing it, also added an example #785

Closed t0theRANCH closed 8 months ago

t0theRANCH commented 10 months ago

I need to use the dylib to import a framework and add some functions to a custom class that I load in the iOS key store class. Can the CI accomplish this? I'm not really sure what it is or how it works.

As for the PR description, do you just want some more details as to how exactly the iOS Keyring and Android Keystore encrypt and save information?

Get Outlook for iOShttps://aka.ms/o0ukef

From: Mirko Galimberti @.> Sent: Thursday, November 23, 2023 1:00:12 PM To: kivy/plyer @.> Cc: t0theRANCH @.>; Mention @.> Subject: Re: [kivy/plyer] Keystore now encrypts data before storing it, also added an example (PR #785)

@misl6 requested changes on this pull request.

Hi @t0theRANCHhttps://github.com/t0theRANCH !

Thank you for taking care of this feature, can you please add some more context by editing the PR description?

Also, I see you're including some dylibs, it's preferable to avoid including pre-built binaries, but instead have a build script (that can run in the CI), can you take care of it?

— Reply to this email directly, view it on GitHubhttps://github.com/kivy/plyer/pull/785#pullrequestreview-1746873002, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVBAYQ3QEL37VVYQMZUMUJLYF6FKZAVCNFSM6AAAAAA7VEOSPOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONBWHA3TGMBQGI. You are receiving this because you were mentioned.Message ID: @.***>

misl6 commented 9 months ago

As for the PR description, do you just want some more details as to how exactly the iOS Keyring and Android Keystore encrypt and save information?

Yes, just some details + links to resources (if applicable), just to give some context to someone else in future.

I need to use the dylib to import a framework and add some functions to a custom class that I load in the iOS key store class. Can the CI accomplish this? I'm not really sure what it is or how it works.

I see, and unfortunately we can't ship any .dylib to iOS App store, unless the .dylib is placed into a (Signed) umbrella framework. The suggestion (the most immediate and the faster way ATM) is to add the needed code in https://github.com/kivy/kivy-ios/tree/master/kivy_ios/recipes/ios/src , so it's available in plyer later when needed.