search

kivy / python-for-android

Turn your Python application into an Android APK
https://python-for-android.readthedocs.io
MIT License
8.36k stars 1.86k forks source link

Can/should we get rid of zope_interface's fix-init patch ? #3083

Open Cheaterman opened 3 days ago

Cheaterman commented 3 days ago

https://github.com/kivy/python-for-android/blob/10c529261d1cb19f1873bcf31db4e3f88c099488/pythonforandroid/recipes/zope_interface/__init__.py#L22

If you check on Kivy Discord (or even in buildozer issues: kivy/buildozer#1601), there's a few mentions (including mine) of twisted failing to build because of zope_interface. It seems to work properly if we remove the fix-init patch, so maybe we're indeed in the future (cf comment in the recipe) and this errors out?

I opened this issue (instead of directly making a PR) to discuss the situation, in particular to check if people manage to properly build projects that use twisted without issues, in which case maybe the fix-init patch isn't the root cause.

AndreMiras commented 1 day ago

Thanks for the report. I would say if it doesn't even build and fail at patching with zope interface, I don't see why not removing it indeed. In the worst case it fails runtime, but it's still some steps further. So yeah feel free to come up with a pull request