search

kiwanami / emacs-calfw

A calendar framework for Emacs
1.17k stars 100 forks source link

Specified Packages-Requires #106

Closed takaxp closed 5 years ago

takaxp commented 7 years ago

'Packages-Requires' is added to each emacs lisp file for individual installation from MELPA.

takaxp commented 7 years ago

According to the comments by purcell for other package, the version of related packages should be specified in `Packages-Requires' for older package.el. But actually I don't know what is the appropriate values for each calfw lisp..., IMO, "0" may be acceptable.

https://github.com/emacs-helm/helm-elscreen/pull/2/files/e569bf05d4eadb98e670c68bdee16ead51906bf2

kiwanami commented 7 years ago

Hi @takaxp Thank you for you PR!

Well, I don't know about older package.el. I should catch up recent information about emacs packaging...

Another PR includes your work. https://github.com/kiwanami/emacs-calfw/pull/105 I should check the PR #105 and close this PR, but it takes much time to check the code.

So, the workaround; after merging your PR checking the PR #105, is reasonable.

Hmm...

takaxp commented 7 years ago

It's OK for me. I think we can close (or reject?) this PR and then continuously handle this issue in #105. I will watch the #105. And also I will comment if needed. Thank you for your kind reply :)