search

kiwi-bdd / Kiwi

Simple BDD for iOS
BSD 3-Clause "New" or "Revised" License
4.14k stars 512 forks source link

Resolve Xcode 9 compatibility issues #702

Closed SergeyKuryanov closed 6 years ago

SergeyKuryanov commented 6 years ago

This address issue #699

This PR updates project to recommended settings, update dependencies and resolve project warnings. There is some runtime issues left, not sure if that should be fixed.

ecaselles commented 6 years ago

Thanks for this @SergeyKuryanov, I will check why travis is not happy and come back to you. Let's get this out of the door before the end of the year 💪

ecaselles commented 6 years ago

@SergeyKuryanov tests crash while running on iPhone 5 (iOS 10.0). It might be related to the 2 build time issues we have in this build or the runtime ones you mention. We should investigate and fix them

ecaselles commented 6 years ago

In case it helps @SergeyKuryanov,

If you run the tests from the command line (as Travis does):

xcodebuild -project Kiwi.xcodeproj -scheme Kiwi-iOS -destination 'platform=iOS Simulator,name=iPhone 5' test

Then you will see in the logs the following line: 

Restarting after unexpected exit or crash in KWLetNodeTest/testItEvaluatesTheDeepestChild;
summary will include totals from previous launches.
ecaselles commented 6 years ago

This PR needs rebasing on top of master after #703 was merged.

ecaselles commented 6 years ago

Closing in favour of #705. Thanks @SergeyKuryanov 🏆