allow the use of notification matcher with async verifier

kiwi-bdd / Kiwi

Simple BDD for iOS

BSD 3-Clause "New" or "Revised" License

4.14k stars 512 forks source link

allow the use of notification matcher with async verifier #714

Closed paulz closed 4 years ago

paulz commented 5 years ago

allow the use of notification matcher with async verifier in constructs like[[@"my notification" shouldEventually] bePosted]; or even shouldNotEventually by keeping observer alive when evaluated multiple times until first notification received

Fixes https://github.com/kiwi-bdd/Kiwi/issues/592

ecaselles commented 5 years ago

Thanks for addressing this @paulz. Could this fix be tested to make sure it behaves as expected? Or do you feel the existing tests cover it?

ecaselles commented 4 years ago

@paulz I am keen to release a new version and would like to include this fix. Would you mind checking my previous comment and letting me know your thoughts please? 🙏 Thanks!

paulz commented 4 years ago

@ecaselles please find resurrected unit tests and added functional tests this should obsolete https://github.com/kiwi-bdd/Kiwi/pull/639

and we are celebrating 5 years anniversary of the PR!

ecaselles commented 4 years ago

Thanks @paulz!

ecaselles commented 4 years ago

This PR closes #639 as @paulz mentioned above.