search

kiwi-cam / homebridge-broadlink-rm

[This fork supports TV accessories] Broadlink RM Mini and Pro plugin for homebridge: https://github.com/nfarina/homebridge
Apache License 2.0
296 stars 96 forks source link

Overreporting Blinds Position Status in 4.4.16-beta.0 #702

Open shanemcw opened 1 month ago

shanemcw commented 1 month ago

Describe the bug Overreporting is status (blinds/shades) in 4.4.16-beta.0

To Reproduce Steps to reproduce the behavior:

  1. Go to logs
  2. See overreporting

Expected behavior Less detailed status reporting as in 4.4.15. In 4.4.15, every increment of the blind position is not reported as shown.

Screenshots

[5/28/2024, 10:00:23 AM] [Broadlink RM pro] Bedroom South Blinds setTargetPosition: updated position to 62 (opening)
[5/28/2024, 10:00:23 AM] [Broadlink RM pro] Bedroom East Blinds setTargetPosition: updated position to 68 (opening)
[5/28/2024, 10:00:24 AM] [Broadlink RM pro] Bedroom South Blinds setTargetPosition: updated position to 63 (opening)
[5/28/2024, 10:00:24 AM] [Broadlink RM pro] Bedroom East Blinds setTargetPosition: updated position to 69 (opening)
[5/28/2024, 10:00:24 AM] [Broadlink RM pro] Bedroom South Blinds setTargetPosition: updated position to 64 (opening)
[5/28/2024, 10:00:24 AM] [Broadlink RM pro] Bedroom East Blinds setTargetPosition: updated position to 70 (opening)
[5/28/2024, 10:00:24 AM] [Broadlink RM pro] Bedroom South Blinds setTargetPosition: updated position to 65 (opening)
[5/28/2024, 10:00:24 AM] [Broadlink RM pro] Bedroom East Blinds setTargetPosition: updated position to 71 (opening)
[5/28/2024, 10:00:25 AM] [Broadlink RM pro] Bedroom South Blinds setTargetPosition: updated position to 66 (opening)
[5/28/2024, 10:00:25 AM] [Broadlink RM pro] Bedroom East Blinds setTargetPosition: updated position to 72 (opening)
[5/28/2024, 10:00:25 AM] [Broadlink RM pro] Bedroom South Blinds setTargetPosition: updated position to 67 (opening)
[5/28/2024, 10:00:25 AM] [Broadlink RM pro] Bedroom East Blinds setTargetPosition: updated position to 73 (opening)
[5/28/2024, 10:00:25 AM] [Broadlink RM pro] Bedroom South Blinds setTargetPosition: updated position to 68 (opening)
[5/28/2024, 10:00:25 AM] [Broadlink RM pro] Bedroom East Blinds setTargetPosition: updated position to 74 (opening)
[5/28/2024, 10:00:25 AM] [Broadlink RM pro] Bedroom South Blinds setTargetPosition: updated position to 69 (opening)
[5/28/2024, 10:00:25 AM] [Broadlink RM pro] Bedroom East Blinds setTargetPosition: updated position to 75 (opening)
[5/28/2024, 10:00:26 AM] [Broadlink RM pro] Bedroom South Blinds setTargetPosition: updated position to 70 (opening)
[5/28/2024, 10:00:26 AM] [Broadlink RM pro] Bedroom East Blinds setTargetPosition: updated position to 76 (opening)
[5/28/2024, 10:00:26 AM] [Broadlink RM pro] Bedroom South Blinds setTargetPosition: updated position to 71 (opening)
[5/28/2024, 10:00:26 AM] [Broadlink RM pro] Bedroom East Blinds setTargetPosition: updated position to 77 (opening)
[5/28/2024, 10:00:26 AM] [Broadlink RM pro] Bedroom South Blinds setTargetPosition: updated position to 72 (opening)
[5/28/2024, 10:00:26 AM] [Broadlink RM pro] Bedroom East Blinds setTargetPosition: updated position to 78 (opening)
[5/28/2024, 10:00:26 AM] [Broadlink RM pro] Bedroom South Blinds setTargetPosition: updated position to 73 (opening)
[5/28/2024, 10:00:26 AM] [Broadlink RM pro] Bedroom East Blinds setTargetPosition: updated position to 79 (opening)
[5/28/2024, 10:00:27 AM] [Broadlink RM pro] Bedroom South Blinds setTargetPosition: updated position to 74 (opening)
[5/28/2024, 10:00:27 AM] [Broadlink RM pro] Bedroom East Blinds setTargetPosition: updated position to 80 (opening)
[5/28/2024, 10:00:27 AM] [Broadlink RM pro] Bedroom South Blinds setTargetPosition: updated position to 75 (opening)
[5/28/2024, 10:00:27 AM] [Broadlink RM pro] Bedroom East Blinds setTargetPosition: updated position to 81 (opening)
[5/28/2024, 10:00:27 AM] [Broadlink RM pro] Bedroom South Blinds setTargetPosition: updated position to 76 (opening)
[5/28/2024, 10:00:27 AM] [Broadlink RM pro] Bedroom East Blinds setTargetPosition: updated position to 82 (opening)
[5/28/2024, 10:00:27 AM] [Broadlink RM pro] Bedroom South Blinds setTargetPosition: updated position to 77 (opening)
[5/28/2024, 10:00:27 AM] [Broadlink RM pro] Bedroom East Blinds setTargetPosition: updated position to 83 (opening)
[5/28/2024, 10:00:28 AM] [Broadlink RM pro] Bedroom South Blinds setTargetPosition: updated position to 78 (opening)
[5/28/2024, 10:00:28 AM] [Broadlink RM pro] Bedroom East Blinds setTargetPosition: updated position to 84 (opening)
[5/28/2024, 10:00:28 AM] [Broadlink RM pro] Bedroom South Blinds setTargetPosition: updated position to 79 (opening)
[5/28/2024, 10:00:28 AM] [Broadlink RM pro] Bedroom East Blinds setTargetPosition: updated position to 85 (opening)
[5/28/2024, 10:00:28 AM] [Broadlink RM pro] Bedroom South Blinds setTargetPosition: updated position to 80 (opening)
[5/28/2024, 10:00:28 AM] [Broadlink RM pro] Bedroom East Blinds setTargetPosition: updated position to 86 (opening)
[5/28/2024, 10:00:28 AM] [Broadlink RM pro] Bedroom South Blinds setTargetPosition: updated position to 81 (opening)
[5/28/2024, 10:00:28 AM] [Broadlink RM pro] Bedroom East Blinds setTargetPosition: updated position to 87 (opening)
[5/28/2024, 10:00:29 AM] [Broadlink RM pro] Bedroom South Blinds setTargetPosition: updated position to 82 (opening)
[5/28/2024, 10:00:29 AM] [Broadlink RM pro] Bedroom East Blinds setTargetPosition: updated position to 88 (opening)
[5/28/2024, 10:00:29 AM] [Broadlink RM pro] Bedroom South Blinds setTargetPosition: updated position to 83 (opening)
[5/28/2024, 10:00:29 AM] [Broadlink RM pro] Bedroom East Blinds setTargetPosition: updated position to 89 (opening)
[5/28/2024, 10:00:29 AM] [Broadlink RM pro] Bedroom South Blinds setTargetPosition: updated position to 84 (opening)
[5/28/2024, 10:00:29 AM] [Broadlink RM pro] Bedroom East Blinds setTargetPosition: updated position to 90 (opening)
[5/28/2024, 10:00:30 AM] [Broadlink RM pro] Bedroom South Blinds setTargetPosition: updated position to 85 (opening)
[5/28/2024, 10:00:30 AM] [Broadlink RM pro] Bedroom East Blinds setTargetPosition: updated position to 91 (opening)
[5/28/2024, 10:00:30 AM] [Broadlink RM pro] Bedroom South Blinds setTargetPosition: updated position to 86 (opening)
[5/28/2024, 10:00:30 AM] [Broadlink RM pro] Bedroom East Blinds setTargetPosition: updated position to 92 (opening)
[5/28/2024, 10:00:30 AM] [Broadlink RM pro] Bedroom South Blinds setTargetPosition: updated position to 87 (opening)
[5/28/2024, 10:00:30 AM] [Broadlink RM pro] Bedroom East Blinds setTargetPosition: updated position to 93 (opening)
[5/28/2024, 10:00:30 AM] [Broadlink RM pro] Bedroom South Blinds setTargetPosition: updated position to 88 (opening)
[5/28/2024, 10:00:30 AM] [Broadlink RM pro] Bedroom East Blinds setTargetPosition: updated position to 94 (opening)
[5/28/2024, 10:00:31 AM] [Broadlink RM pro] Bedroom South Blinds setTargetPosition: updated position to 89 (opening)
[5/28/2024, 10:00:31 AM] [Broadlink RM pro] Bedroom East Blinds setTargetPosition: updated position to 95 (opening)
[5/28/2024, 10:00:31 AM] [Broadlink RM pro] Bedroom South Blinds setTargetPosition: updated position to 90 (opening)
[5/28/2024, 10:00:31 AM] [Broadlink RM pro] Bedroom East Blinds setTargetPosition: updated position to 96 (opening)
[5/28/2024, 10:00:31 AM] [Broadlink RM pro] Bedroom South Blinds setTargetPosition: updated position to 91 (opening)
[5/28/2024, 10:00:31 AM] [Broadlink RM pro] Bedroom East Blinds setTargetPosition: updated position to 97 (opening)
[5/28/2024, 10:00:31 AM] [Broadlink RM pro] Bedroom South Blinds setTargetPosition: updated position to 92 (opening)
[5/28/2024, 10:00:31 AM] [Broadlink RM pro] Bedroom East Blinds setTargetPosition: updated position to 98 (opening)
[5/28/2024, 10:00:32 AM] [Broadlink RM pro] Bedroom South Blinds setTargetPosition: updated position to 93 (opening)
[5/28/2024, 10:00:32 AM] [Broadlink RM pro] Bedroom East Blinds setTargetPosition: (stop window covering)
[5/28/2024, 10:00:32 AM] [Broadlink RM pro] Bedroom South Blinds setTargetPosition: updated position to 94 (opening)
[5/28/2024, 10:00:32 AM] [Broadlink RM pro] Bedroom South Blinds setTargetPosition: updated position to 95 (opening)
[5/28/2024, 10:00:32 AM] [Broadlink RM pro] Bedroom South Blinds setTargetPosition: updated position to 96 (opening)
[5/28/2024, 10:00:33 AM] [Broadlink RM pro] Bedroom South Blinds setTargetPosition: updated position to 97 (opening)
[5/28/2024, 10:00:33 AM] [Broadlink RM pro] Bedroom South Blinds setTargetPosition: updated position to 98 (opening)
[5/28/2024, 10:00:33 AM] [Broadlink RM pro] Bedroom South Blinds setTargetPosition: (stop window covering)
[5/28/2024, 10:35:35 AM] [homebridge-broadlink-rm-pro] This plugin slows down Homebridge. The read handler for the characteristic 'Current Temperature' was slow to respond! See https://homebridge.io/w/JtMGR for more info.
[5/28/2024, 10:35:35 AM] [homebridge-broadlink-rm-pro] This plugin slows down Homebridge. The read handler for the characteristic 'Current Relative Humidity' was slow to respond! See https://homebridge.io/w/JtMGR for more info.
shanemcw commented 1 month ago

On further thought, it looks like from the logs the targetPosition is being sent one at a time in fine detail instead of just the end state. I.e. "set to 1% and stop there" "OK now set to open to 2% and stop there," "OK now set to 3% and stop there" and so forth, instead of "set to 100% and stop there" once?

shanemcw commented 1 month ago

4.4.15 behavior:

[5/29/2024, 12:12:41 PM] [Broadlink RM pro] Study South Blinds setTargetPosition: (currentPosition: 100)
[5/29/2024, 12:12:41 PM] [Broadlink RM pro] Study South Blinds setTargetPosition: currently 100%, moving to 50%
[5/29/2024, 12:12:41 PM] [Broadlink RM pro] Study South Blinds setTargetPosition: 14.499999999999998s (29 / 100 * 50) until auto-stop
[5/29/2024, 12:12:55 PM] [Broadlink RM pro] Study South Blinds setTargetPosition: (stop window covering)
[5/29/2024, 12:13:28 PM] [Broadlink RM pro] Study South Blinds setTargetPosition: (currentPosition: 50)
shanemcw commented 1 month ago

On further thought, this new behavior may animate the blinds while moving in the Home app. The request in this ticket is to suppress the logging of the incremental current state updates while in transition from the initial to the target state.