kiwi-cam / homebridge-broadlink-rm

[This fork supports TV accessories] Broadlink RM Mini and Pro plugin for homebridge: https://github.com/nfarina/homebridge
Apache License 2.0
302 stars 96 forks source link

Version 4.4.18 Ping to devices not work anymore #725

Open creepshow007 opened 1 month ago

creepshow007 commented 1 month ago

Describe the bug In Version 4.4.18 Ping to devices like TV etc. not work anymore. Back to Version 4.4.17 and it works again

To Reproduce

Expected behavior Ping to devices like TV etc. should work

Screenshots

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context

kiwi-cam commented 1 month ago

This is functionality I use too - and I haven't noticed any issues. Would you be able to enable debuging on one of these accessories and capture some logs of the device going online and offline?

creepshow007 commented 1 month ago

Hi Unfortunaltely I don’t know how to enable debugging.

I use this code:

           {
                "name": "Samsung TV",
                "type": "switch",
                "pingIPAddress": "192.168.1.30",
                "pingFrequency": 2,
                "pingIPAddressStateOnly": true,
                "pingUseArp": false,
                "pingGrace": 10,
                "data": {
                    "on": "HEXCODE",
                    "off": "HEXCODE"
                }
            },
            {
                "name": "Onkyo TX-NR509",
                "type": "switch",
                "pingIPAddress": "192.168.1.31",
                "pingFrequency": 2,
                "pingIPAddressStateOnly": true,
                "pingUseArp": false,
                "pingGrace": 10,
                "data": {
                    "on": "HEXCODE",
                    "off": "HEXCODE"
                }
            },

When I switch on the TV or the Onkyo Receiver, then with the new version 4.4.18 the accessorie in Homebridge does not change the status on/off. With old version 4.4.17 it always changed the status on/off correctly.

Ping with terminal on my Mac acts correctly. When I switch on the devices, then ping works. When I switch off devices then ping stops working.

cattastrophe0 commented 3 weeks ago

I'm seeing the same behavior. When the plugin starts, it pings the TV state once and then doesn't ping again. I downgraded to 4.4.17 and it started working again, and then upgraded and it stopped. I'm not sure if this is helpful, but here are the logs from when I downgraded and then re-upgraded, it hasn't pinged since 11:51 as seen in this snippet:


[8/19/2024, 11:48:57 PM] Homebridge v1.8.4 (HAP v0.12.2) (BroadlinkRM) is running on port 48333.
[8/19/2024, 11:48:57 PM] 

NOTICE TO USERS AND PLUGIN DEVELOPERS
> Homebridge 2.0 is on the way and brings some breaking changes to existing plugins.
> Please visit the following link to learn more about the changes and how to prepare:
> https://github.com/homebridge/homebridge/wiki/Updating-To-Homebridge-v2.0

[8/19/2024, 11:48:57 PM] TV C584 is running on port 60424.
[8/19/2024, 11:48:57 PM] Please add [TV C584] manually in Home app. Setup Code: 265-72-141
[INFO] Adding RF Support to device ec0bae3df3a4 with type 649b
[8/19/2024, 11:48:57 PM] [BroadlinkRM] [INFO] Discovered Broadlink RM4 Pro (649b) at 192.168.0.29 (ec:0b:ae:3d:f3:a4)
[8/19/2024, 11:48:58 PM] [BroadlinkRM] TV getSwitchState: true
[8/19/2024, 11:49:30 PM] [Homebridge UI] Running Command: npm install -g homebridge-broadlink-rm-pro@4.4.17
[8/19/2024, 11:49:40 PM] [BroadlinkRM] Restarting child bridge...
[8/19/2024, 11:49:40 PM] Got SIGTERM, shutting down child bridge process...
[8/19/2024, 11:49:45 PM] [BroadlinkRM] Child bridge process ended
[8/19/2024, 11:49:45 PM] [BroadlinkRM] Process Ended. Code: 143, Signal: null
[8/19/2024, 11:49:52 PM] [BroadlinkRM] Restarting Process...
[8/19/2024, 11:49:52 PM] [BroadlinkRM] Launched child bridge with PID 81596
[8/19/2024, 11:49:53 PM] Registering platform 'homebridge-broadlink-rm-pro.BroadlinkRM'
[8/19/2024, 11:49:53 PM] [BroadlinkRM] Loaded homebridge-broadlink-rm-pro v4.4.17 child bridge successfully
[8/19/2024, 11:49:53 PM] Loaded 0 cached accessories from cachedAccessories.0E9CA6672F0A.
[8/19/2024, 11:49:53 PM] [BroadlinkRM] [INFO] Automatically discovering Broadlink RM devices.
[8/19/2024, 11:49:53 PM] [BroadlinkRM] [INFO] Running Homebridge Broadlink RM Plugin version 4.4.17
[8/19/2024, 11:49:53 PM] [BroadlinkRM] TV Accessory Ready
[8/19/2024, 11:49:53 PM] [BroadlinkRM] 
[8/19/2024, 11:49:53 PM] [BroadlinkRM] **************************************************************************************************************
[8/19/2024, 11:49:53 PM] [BroadlinkRM] You added TVs in your configuration!
[8/19/2024, 11:49:53 PM] [BroadlinkRM] Due to a HomeKit limitation you need to add any TVs to the Home app by using the Add Accessory function.
[8/19/2024, 11:49:53 PM] [BroadlinkRM] There you'll find your TVs and you can use the same PIN as you using for this HomeBridge instance.
[8/19/2024, 11:49:53 PM] [BroadlinkRM] **************************************************************************************************************
[8/19/2024, 11:49:53 PM] [BroadlinkRM] 
[8/19/2024, 11:49:53 PM] Homebridge v1.8.4 (HAP v0.12.2) (BroadlinkRM) is running on port 48333.
[8/19/2024, 11:49:53 PM] 

NOTICE TO USERS AND PLUGIN DEVELOPERS
> Homebridge 2.0 is on the way and brings some breaking changes to existing plugins.
> Please visit the following link to learn more about the changes and how to prepare:
> https://github.com/homebridge/homebridge/wiki/Updating-To-Homebridge-v2.0

[8/19/2024, 11:49:53 PM] TV C584 is running on port 61065.
[8/19/2024, 11:49:53 PM] Please add [TV C584] manually in Home app. Setup Code: 265-72-141
[INFO] Adding RF Support to device ec0bae3df3a4 with type 649b
[8/19/2024, 11:49:53 PM] [BroadlinkRM] [INFO] Discovered Broadlink RM4 Pro (649b) at 192.168.0.29 (ec:0b:ae:3d:f3:a4)
[8/19/2024, 11:49:53 PM] [BroadlinkRM] TV getSwitchState: false
[8/19/2024, 11:49:54 PM] [BroadlinkRM] TV getSwitchState: false
[8/19/2024, 11:49:55 PM] [BroadlinkRM] [UPDATE AVAILABLE] Version v4.4.18 of Homebridge Broadlink RM Pro is available. The release notes can be found here: https://github.com/kiwi-cam/homebridge-broadlink-rm/releases/
[8/19/2024, 11:50:06 PM] [BroadlinkRM] TV getSwitchState: false
[8/19/2024, 11:50:16 PM] [BroadlinkRM] TV getSwitchState: false
[8/19/2024, 11:50:26 PM] [BroadlinkRM] TV getSwitchState: false
[8/19/2024, 11:50:36 PM] [BroadlinkRM] TV getSwitchState: false
[8/19/2024, 11:50:46 PM] [BroadlinkRM] TV getSwitchState: false
[8/19/2024, 11:50:50 PM] [Homebridge UI] Running Command: npm install -g homebridge-broadlink-rm-pro@4.4.18
[8/19/2024, 11:50:56 PM] [BroadlinkRM] TV getSwitchState: false
[8/19/2024, 11:51:00 PM] [BroadlinkRM] Restarting child bridge...
[8/19/2024, 11:51:00 PM] Got SIGTERM, shutting down child bridge process...
[8/19/2024, 11:51:05 PM] [BroadlinkRM] Child bridge process ended
[8/19/2024, 11:51:05 PM] [BroadlinkRM] Process Ended. Code: 143, Signal: null
[8/19/2024, 11:51:12 PM] [BroadlinkRM] Restarting Process...
[8/19/2024, 11:51:13 PM] [BroadlinkRM] Launched child bridge with PID 81685
[8/19/2024, 11:51:13 PM] Registering platform 'homebridge-broadlink-rm-pro.BroadlinkRM'
[8/19/2024, 11:51:13 PM] [BroadlinkRM] Loaded homebridge-broadlink-rm-pro v4.4.18 child bridge successfully
[8/19/2024, 11:51:13 PM] Loaded 0 cached accessories from cachedAccessories.0E9CA6672F0A.
[8/19/2024, 11:51:13 PM] [BroadlinkRM] [INFO] Automatically discovering Broadlink RM devices.
[8/19/2024, 11:51:13 PM] [BroadlinkRM] [INFO] Running Homebridge Broadlink RM Plugin version 4.4.18
[8/19/2024, 11:51:13 PM] [BroadlinkRM] TV Accessory Ready
[8/19/2024, 11:51:13 PM] [BroadlinkRM] 
[8/19/2024, 11:51:13 PM] [BroadlinkRM] **************************************************************************************************************
[8/19/2024, 11:51:13 PM] [BroadlinkRM] You added TVs in your configuration!
[8/19/2024, 11:51:13 PM] [BroadlinkRM] Due to a HomeKit limitation you need to add any TVs to the Home app by using the Add Accessory function.
[8/19/2024, 11:51:13 PM] [BroadlinkRM] There you'll find your TVs and you can use the same PIN as you using for this HomeBridge instance.
[8/19/2024, 11:51:13 PM] [BroadlinkRM] **************************************************************************************************************
[8/19/2024, 11:51:13 PM] [BroadlinkRM] 
[8/19/2024, 11:51:13 PM] Homebridge v1.8.4 (HAP v0.12.2) (BroadlinkRM) is running on port 48333.
[8/19/2024, 11:51:13 PM] 

NOTICE TO USERS AND PLUGIN DEVELOPERS
> Homebridge 2.0 is on the way and brings some breaking changes to existing plugins.
> Please visit the following link to learn more about the changes and how to prepare:
> https://github.com/homebridge/homebridge/wiki/Updating-To-Homebridge-v2.0

[8/19/2024, 11:51:13 PM] TV C584 is running on port 62162.
[8/19/2024, 11:51:13 PM] Please add [TV C584] manually in Home app. Setup Code: 265-72-141
[INFO] Adding RF Support to device ec0bae3df3a4 with type 649b
[8/19/2024, 11:51:13 PM] [BroadlinkRM] [INFO] Discovered Broadlink RM4 Pro (649b) at 192.168.0.29 (ec:0b:ae:3d:f3:a4)
[8/19/2024, 11:51:14 PM] [BroadlinkRM] TV getSwitchState: false