search

kiwibrowser / src.next

Source-code for Kiwi Next, a Kiwi Browser auto-rebased with latest Chromium
BSD 3-Clause "New" or "Revised" License
2.32k stars 295 forks source link

Can nightmode be improved #1181

Open Sickhead01 opened 2 months ago

Sickhead01 commented 2 months ago

When night mode it on it messes certain images and seekbars on websites as shown below.

Night mode on: photo_2024-09-04_09-03-09 photo_2024-09-04_09-03-23

Night mode off: photo_2024-09-04_09-03-15 photo_2024-09-04_09-03-28

The seekbar is especially the intolerable part because on a lot of websites i can't see it at all so i have to disable night mode when try to watch videos. Edge has a setting in the flags called "Auto Dark Mode for Web Contents" and it gives you the option "Enabled with selective inversion of non-image elements". This fixes most of the image changes i've seen (except the seekbar problem), but that setting doesn't exist in Kiwi's flags. Could improvements be made to night mode to fix these issues?

Losvayne commented 2 months ago

Use temporarily unexpire flag fool!

Sickhead01 commented 2 months ago

Use temporarily unexpire flag fool!

I don't know what that is/does, asswipe

sjain882 commented 2 months ago

Would be great if we could just use the official Chrome app's dark theming ("darken websites"). The colours and contrast are absolutely perfect and it doesn't have these issues

Use temporarily unexpire flag fool!

I don't know what that is/does, asswipe

They mean - first enable chrome://flags/#temporary-unexpire-flags-m122 then relaunch, then enable chrome://flags/#enable-force-dark

However, even after doing this, I can't get replicate Chromes lovely grey dark theme engine. Seems Kiwi replaced this entirely with it's own buggy amoled implementation :/

Best solution would be to restore the contrast slider if possible (#767), however I feel there's a reason it was removed (new dark theme engine maybe).

Also, I have grey (colour images) mode selected in the night mode options, but it is amoled black on most sites still, or too dark grey

PawelGu commented 1 month ago

Or maybe just use Dark Reader extension?

Sickhead01 commented 1 month ago

Or maybe just use Dark Reader extension?

Dark reader slows browsers down. That's been an issue with it for while now. Plus it also has these issues.

Also why download an extension to get an already built in feature? That's literally just addon extra bloat that needlessly uses up more resources. It's probably just a me thing but i absolutely hate having multiple apps/extension/addons/etc that do the same thing and avoid doing so where ever i can, so i'm asking for what's already there to be improved