kiwibrowser / src.next

Source-code for Kiwi Next, a Kiwi Browser auto-rebased with latest Chromium
BSD 3-Clause "New" or "Revised" License
2.24k stars 286 forks source link

WebUSB non-functional after Chromium upstream fix #738

Closed parkerlreed closed 1 year ago

parkerlreed commented 1 year ago

Describe the bug Version 106 introduced a bug preventing the WebUSB dialog from appearing. Patch was submitted upstream and has been merged into src.next as of 5 days ago. Still non-functional on latest builds.

To Reproduce Visit any site with WebUSB functionality. Using https://yume-chan.github.io/ya-webadb/ as my test. Clicking add and then USB should result in a dialog appearing.

Expected behavior Dialog box popup allowing to select USB device

Screenshots image

Smartphone (please complete the following information):

Additional context Original bug report mentioning behavior https://github.com/trezor/trezor-suite/issues/6512 Chromium upstream bug report https://bugs.chromium.org/p/chromium/issues/detail?id=1373502#c29 Patch https://chromium.googlesource.com/chromium/src/+/033714e395fbcd6a5eaecbeb265cee6b09da6311 Merged in src.next chromium as of 3c8880279187ab7451fed8fc349bbf01d977896c Using the com.kiwibrowser.browser-arm64-3285057370-github.apk build

parkerlreed commented 1 year ago

Note: I just realized I forgot to enable #enable-experimental-web-platform-features

No change even with that enabled

parkerlreed commented 1 year ago

Ok this may not be limited to Kiwi

Chrome Stable 106.0.5249.126 works

Chrome Beta 107.0.5304.36 does NOT work

Chrome Dev 108.0.5359.10 works

Looks like it has regressed again between 106 and 107 but fixed again after 108

parkerlreed commented 1 year ago

image

Best guess is the revert screwed it up and the revert of the revert fixed it again

parkerlreed commented 1 year ago

Hell yes! Got fixed in the latest 107.0.5304.66