kiwibrowser / src.next

Source-code for Kiwi Next, a Kiwi Browser auto-rebased with latest Chromium
BSD 3-Clause "New" or "Revised" License
2.25k stars 286 forks source link

Ability to turn on dark mode just for kiwi and not for websites #931

Open Redn2000 opened 1 year ago

Redn2000 commented 1 year ago

As it is right now after the recent Play Store update, there doesn't seem to be a way to turn off dark mode for websites while still having it enabled for Kiwi Browser. I would like to, if possible, be able to do this or alternatively be able to disable the built-in dark mode for certain sites.

Describe alternatives you've considered I was able to find a temporary setting in kiwi://flags, but this may be removed in later chrome updates since I had to also enable legacy flags. This is also very limited.

Additional context Previously I was using dark reader for websites, but after the recent update I found that certain elements on websites get broken with the now force-enabled chrome/kiwi dark mode theme, even with dark reader off. The only way to fix this was either turning dark mode off, which also makes kiwi very bright, or enabling a legacy flag to allow a partial disable of the forced dark mode on sites.

lje commented 1 year ago

enable Dark mode from settings > Themes

For me this makes pages dark as well (Samsung S21 FE). I'd like the old behaviour back as well, dark top bar (the one with clock, wifi, battery, ...) with white tabs/web pages.

Redn2000 commented 1 year ago

enable Dark mode from settings > Themes

For me this makes pages dark as well (Samsung S21 FE). I'd like the old behaviour back as well, dark top bar (the one with clock, wifi, battery, ...) with white tabs/web pages.

It's not an elegant fix, but these are the flags I had to enable to attempt getting the old behavior back:

chrome://flags/#temporary-unexpire-flags-m114

chrome://flags/#temporary-unexpire-flags-m115

chrome://flags/#darken-websites-checkbox-in-themes-setting

And I disabled this flag:

chrome://flags/#enable-force-dark

Unfortunately Incognito behavior is extremely temperamental with this even after the changes, where it force applies sometimes and not others. I don't know how long these flags will be available, but this is all I could find for now.

kiwibrowser commented 1 year ago

Just to be sure to understand correctly: What you want is that when Dark theme is checked, that instead of following the Dark theme provided by the website, then we override the website style (that have a light and dark theme), so the light theme of the website is always selected in priority, before the dark theme. To be in the same situation as with Light theme in terms of web pages appearance

Is this correct ?

lje commented 1 year ago

This is the new look (completely bright): New

And this is what it looked before the update (quickly faked with Paint): dark system status bar above Kiwi but bright browser.I have not found an option to restore it that way: Old

Redn2000 commented 1 year ago

Just to be sure to understand correctly: What you want is that when Dark theme is checked, that instead of following the Dark theme provided by the website, then we override the website style (that have a light and dark theme), so the light theme of the website is always selected in priority, before the dark theme. To be in the same situation as with Light theme in terms of web pages appearance

Is this correct ?

Sorry, I'll try to specify better. I'll include pictures of a Nitter instance below to show what I mean, but it's not that I want the light theme to take priority on sites when the browser's dark theme is enabled, what I'm instead looking for is the option to not allow Kiwi to apply a theme to a site at all, while still having just the browser in dark mode.

Previously this was the case and was why I could use (prefer) Dark Reader for example. Though now what happens is that even if a website does not have a dark theme (or has its own, negating the need), simply by having Kiwi's dark mode (not night mode) turned on, elements on the page including images are darkened anyways and they break.

It's hard to tell because the website themes the search bar, but with the Kiwi light theme on, dark reader off, and night mode off, this is what a Nitter page looks like: IMG_20230731_173850

This is what happens when I just turn the Kiwi dark theme on now. And same as before, where I still have dark reader off and night mode off. In this case, you can see it kills the top blue banner which is usually a picture on a regular user's profile, along with the red text: IMG_20230731_173656