search

kiwibrowser / src.next

Source-code for Kiwi Next, a Kiwi Browser auto-rebased with latest Chromium
BSD 3-Clause "New" or "Revised" License
2.21k stars 285 forks source link

Find in page search menu overflows the edge of screen #943

Open amit-katyal opened 1 year ago

amit-katyal commented 1 year ago

Describe the bug When tab switcher option is set to desktop, find in page search menu overflows the left edge of screen in mobile devices.

To Reproduce Steps to reproduce the behavior:

  1. Set toolbar to bottom toolbar
  2. In settings, set tab switcher option to desktop (like a computer)
  3. Open a webpage
  4. Open find in page search menu, it will overflow the left edge of screen

Expected behavior Find in page search menu should not overflow the edge of screeen

Screenshots Screenshot_20230730-114614

Smartphone (please complete the following information):

Additional context Seems to be sizing and indentation issue, find in page search menu covers some of the top part of URL search bar. Plus button on right seems to be the cause of this overflow.

zachpoblete commented 5 months ago

This is still a bug.

debiedowner commented 3 months ago

I have the same bug, but the Find In Page toolbar overflows even more, so it's almost unusable, I have to type without being able to see anything.

image

This is presumably due to the size of my phone; when I use adb shell wm density to double the screen area, the Find In Page toolbar is fully visible. It has the same fixed right padding, which is probably the source of the problem.

Also, I've found that changing to bottom toolbar is not required, the issue is present when using top toolbar as well, you just need to be using desktop-style tab switcher.