[crash] Extension cannot ask to get control over a domain

kiwibrowser / src.next

Source-code for Kiwi Next, a Kiwi Browser auto-rebased with latest Chromium

BSD 3-Clause "New" or "Revised" License

2.2k stars 281 forks source link

[crash] Extension cannot ask to get control over a domain #98

Open sijanec opened 3 years ago

sijanec commented 3 years ago

Extension SponsorBlock (from Chrome webstore) will crash the Kiwi Browser app when flipping the switch to enable third party YouTube frontend or adding a third party YouTube frontend domain.

I assume this is because asking for control over another domain inside an extension is not possible under Chromium for Android.

kiwibrowser commented 3 years ago

Diagnosis (not resolution): The crash is because of the window that asks the permission for additional permission doesn't exist in Kiwi. On Chromium Desktop this is a balloon-type notification with a confirm dialog.

pr0nstache commented 1 year ago

I used SponsorBlock until recently (last week) by manually enabling the permissions from chrome://extensions, and it worked fine with Invidious websites. Now, even with the permissions manually granted, I still crash when enabling the "Support 3rd Party YouTube Sites" toggle.

I made and issue for SponsorBlock here: https://github.com/ajayyy/SponsorBlock/issues/1656#issue-1560880569

smashedr commented 2 months ago

Are there any plans to fix this? Are permissions requests not going to be supported by Kiwi?

For reference, requesting permissions via this method:

await chrome.permissions.request({
    origins: ['*://*/*'],
})

Fails in both the Popup and Options Page with the error:

Uncaught (in promise) Error: Could not find an active window.