search

kiwicom / gitlab-unfurly

Serverless Slack bot for unfurling GitLab URLs.
MIT License
39 stars 7 forks source link

Remove docker requirement #15

Closed carlin-q-scott closed 4 years ago

carlin-q-scott commented 4 years ago

I tried deploying this but it requires docker for some reason. Is that a necessary requirement?

aexvir commented 4 years ago

Hi Carlin, Docker is needed for dockerizePip, which allows building wheels cross-systems and ensures compatibility with the lambda runtime. With that said... I don't see why any of our requirements would need it, so I'm pretty sure we can remove it safely 🙂

carlin-q-scott commented 4 years ago

Excellent. I set it to false so that Windows users can re-enable it in #16