kiwicom / margarita

[not actively maintained] Mobile and Web application implementing Kiwi.com Tequila API
https://margarita.kiwi.com/
MIT License
209 stars 42 forks source link

The Tequila API related Issues. #116

Closed FilipMessa closed 3 years ago

FilipMessa commented 5 years ago

If you realize some issue related to Tequila API pls write it here. From time to time we will summarize it and push to Tequila developers.

PLS don't forget that is public so be aware of sensitive data!!!

FilipMessa commented 5 years ago

I missing documentation for API response. For example, when I call location API, I get an array of location, some fields are self-explanatory by their name, but there is a type field and I do not know how many types of values exists for it.

FilipMessa commented 5 years ago

Delays

JosefDuda commented 5 years ago

Search_api

route - Naming should be updated according to glossary https://kiwi.wiki/kiwi/handbook/#/comms/glossary across endpoints. Instead of route, segments will be probably more suitable.

route[x].carrier.name - Carrier name is missing in response and only code is currently available. Should be added to unify response with other endpoints where this value is available.

route[x].airline - Unify carrier related props naming. airline inside route object should be renamed to carrier to unify it with operating_carrier which is also present on the same object.

JosefDuda commented 5 years ago

Booking_api

transfers - Missing description, seems to be always just empty array.

segments - Missing description, seems to be always just empty array.

route - Missing description, confusing compared to route array in search_api with completely different content. Content is similar to routes from search_api but there are still inconsistencies. Search routes contains [ "PRG", "FRA" ], [ "FRA", "PRG" ] for return flight. But booking route is just [ "PRG", "FRA" ] for similar case, so I cannot distinguish if it’s one-way or return flight.

flights - Content and structure seems to be quite similar to route from search_api. Consider if naming and maybe even content can be unified. For example departure city is called cityFrom on one endpoint and src_name on second one.

flights[x].airline - It looks like data can be cleaned or description with differences should be added. For example repeating code value VY (for Vueling) is present as code, iata, iatacode and it can be confusing which one should be used.

flights[x].airline.Name - Name is the only property inside airline object which starts with capital letter. Naming should be unified.

baggage - Baggages related part should be updated. Current sample schema on website only contains bags section, but there is warning in response that this object is deprecated. There is also another luggage array with all baggage limits, which is slightly confusing. It looks from response that new correct way is to use baggage object. Which is not documented, so it is always not clear which values I can get from it.

aalises commented 5 years ago

Search API

The search endpoint with different sort parameter values does not work for all cases. So far sort=price and sort=quality work but sort=duration does not, the results are equivalent to the price sorting...

JosefDuda commented 5 years ago

Tequila website