Refactor the PassengerCard

kiwicom / margarita

[not actively maintained] Mobile and Web application implementing Kiwi.com Tequila API

https://margarita.kiwi.com/

MIT License

209 stars 42 forks source link

Refactor the PassengerCard #853

Closed FilipMessa closed 5 years ago

FilipMessa commented 5 years ago

summary

move the getTitle into the helpers.js file
split the PassengerCard into smaller components
removed icons props, simplify types

Squash and merge pls

netlify[bot] commented 5 years ago

Storybook from packages/universal-components

Built with commit 655c0d6591b892c0122a8e8047b64372c1097519

https://deploy-preview-853--kiwicom-universal-components.netlify.com

aalises commented 5 years ago

LGTM. The only thing is that the passengerCount variable name is a little bit confusing to me with this name, maybe renaming it to something like passengerIndex would be clearer, idk

FilipMessa commented 5 years ago

@aalises changed