search

kiwicom / margarita

[not actively maintained] Mobile and Web application implementing Kiwi.com Tequila API
https://margarita.kiwi.com/
MIT License
208 stars 42 forks source link

Upgrading to latest expo #927

Closed bugsniper closed 3 years ago

bugsniper commented 4 years ago

PR

RobinCsl commented 4 years ago

Hi @bugsniper 👋

Thank you for your contribution.

As explained in the README, Margarita is not actively maintained anymore and I doubt any capacity will be granted to take a proper look at your pull request.

That being said, I had a quick look and can provide some feedback: there are a few hardcoded values related to your organisation "Dragan" and that would prevent the PR from being mergeable. In addition, the locale and currency were changed to RUB and RU in a few places and we would probably prefer to keep EUR and EN as default values. Finally, there are a few seemingly unnecessary console.log calls, most likely used for debugging purposes during development.

Note that addressing the comments will not mean that your PR will be merged as no capacity is currently devoted to maintaining Margarita properly.

If you have any questions about Tequila, I can forward them to the relevant people.

Have a great day and thanks again for your interest in Margarita!

RobinCsl commented 3 years ago

I will archive the repository since there are no current plans to maintain it.

Thanks again for your interest in Margarita and contribution!