search

kiwicom / mobile

:calling: Kiwi.com mobile app written in React Native
https://www.kiwi.com/en/
MIT License
140 stars 33 forks source link

Rename fast track translation keys #1584

Closed vblazenka closed 5 years ago

RobinCsl commented 5 years ago

@vblazenka I had to force push your branch and amend your commits since you had committed some tokens... Please, be careful. Hopefully, I did not lose any of your work in the process.

vblazenka commented 5 years ago

@tbergq are you sure? It didn't add any prefix... that's why I added it manually

tbergquist-godaddy commented 5 years ago

@tbergq are you sure? It didn't add any prefix... that's why I added it manually

Take any string from Hotels.js, log into phraseApp, and you will see it has been added there with .mobile as prefix.

Also, check how we use it in the application. Our code adds the prefix where it is needed. Since we are not 🐒 we don't want to write this prefix that mobile team for some reason insists on repeating everywhere. We are smarter than that 😊

vblazenka commented 5 years ago

@tbergq are you sure? It didn't add any prefix... that's why I added it manually

Take any string from Hotels.js, log into phraseApp, and you will see it has been added there with .mobile as prefix.

Also, check how we use it in the application. Our code adds the prefix where it is needed. Since we are not 🐒 we don't want to write this prefix that mobile team for some reason insists on repeating everywhere. We are smarter than that 😊

I see that yeah. But when I ran deploy-translations the script didn't add any mobile. prefix. So I had to do the mobile. part manually.

tbergquist-godaddy commented 5 years ago

Where did you expect the prefix to be added?

vblazenka commented 5 years ago

Where did you expect the prefix to be added?

Well if I named my key mmb.fast_track.banner.description.bergamo.bergamo_stopover and screenshot I expected to see mobile.mmb.fast_track.banner.description.bergamo.bergamo_stopover on the PhraseApp if I understood exactly.

tbergquist-godaddy commented 5 years ago

Well, if you want to call your keys mobile.mmb.your_key I woun't stop you, but know that it will be uploaded to phraseApp as mobile.mobile.mmb.your_key