search

kiwicom / mobile

:calling: Kiwi.com mobile app written in React Native
https://www.kiwi.com/en/
MIT License
140 stars 33 forks source link

Fix broken react-library.gradle #1673

Closed tbergquist-godaddy closed 5 years ago

tbergquist-godaddy commented 5 years ago

This file was created on 31st October 2018, it seems to be a copy paste of react.gradle with maybe some tiny modifications.

The original file has changed a lot, and this is not reflected in our react-library.gradle

One should be able to fix it mostly by comparing the changelog of the file from react-native and apply to ours. Note that we have had some changes to this file as well since it was created.

tbergquist-godaddy commented 5 years ago

The most important thing is that hermes does not work when our rnkiwimobile framework is released. This needs to be fixed.

Blackhex commented 5 years ago

MR #1676 fixes the Hermes loading problem but does not update the rect-library.gradle.

tbergquist-godaddy commented 5 years ago

Seems this is working for now. Closing