Shared: Use orbit-react-native in CloseButton

kiwicom / mobile

:calling: Kiwi.com mobile app written in React Native

https://www.kiwi.com/en/

MIT License

140 stars 33 forks source link

Closed tbergquist-godaddy closed 5 years ago

tbergquist-godaddy commented 5 years ago

Let me have a second look at it. Definitely the buttons should act the same 🤔

tbergquist-godaddy commented 5 years ago

The opacity is matching the buttons in the native app, so I would say it is an improvement, we should just need to use the orbit button everywhere 😄

The activeOpacity however is coming way to late yes. I want to investigate it a bit.

tbergquist-godaddy commented 5 years ago

Ok, definitely not ready yet, there is no ripple effect on android either. I will see if there is some other component that qualifies.

Closing this MR.