search

kiwicom / mobile

:calling: Kiwi.com mobile app written in React Native
https://www.kiwi.com/en/
MIT License
140 stars 33 forks source link

Upgrade @kiwicom/account and pass bridge function #1719

Closed tbergquist-godaddy closed 4 years ago

tbergquist-godaddy commented 4 years ago

Cleanup code on ios since it was broken And move it to RNModules

tbergquist-godaddy commented 4 years ago

@RobinCsl, if you want to test that the method is there, the easiest way is to just add console.warn(NativeModules.RNAccountManager.accountDeleted); to WithAccountStack.js

@sjavora , there were some syntax errors, so I had to fix them. I also moved to Bridge module to RNModules where the rest of the bridge modules lives. Please verify that I did not break anything.

tbergquist-godaddy commented 4 years ago

also, @RobinCsl , I didn't test on android yet. I want to do that after this one has been merged.

tbergquist-godaddy commented 4 years ago

What exactly was not building? I tried it before submitting and had no errors.

It was missing an ; in RNKiwiViewController.m line 240, and NSNotificationName was placed before the import of the .h file, so it was not defined.

And it did not build for me 😊

sjavora commented 4 years ago

Oh yeah, I was building a different target - that explains why those build errors didin't show up /facepalm