search

kiwicom / orbit-swiftui

Kiwi.com Orbit design system library
MIT License
132 stars 23 forks source link

Update `ButtonLink` design #610

Closed PavelHolec closed 1 year ago

PavelHolec commented 1 year ago

Also partially implements https://github.com/kiwicom/orbit-swiftui/issues/605 by application on Button and SocialButton

https://github.com/kiwicom/orbit-swiftui/assets/35844477/731a3fdd-e662-4be8-b579-a962868d9ef2

https://github.com/kiwicom/orbit-swiftui/assets/35844477/132bdd45-4444-4f86-ae95-74a5773b8845

https://github.com/kiwicom/orbit-swiftui/assets/35844477/98a9e473-d264-4b99-83f2-9bd0eb6bdbed

sjavora commented 1 year ago

I assume the changes in alignment of titles/icons in buttons are intentional?

PavelHolec commented 1 year ago

I assume the changes in alignment of titles/icons in buttons are intentional?

Those for Button and SocialButton weren't - should be fixed now.

sjavora commented 1 year ago

buttonSize could be replaced with the native controlSize for iOS 15+.