kiwicom / orbit-swiftui

Kiwi.com Orbit design system library
MIT License
132 stars 23 forks source link

Extract illustrations to a separate target #693

Closed sjavora closed 1 year ago

sjavora commented 1 year ago

This should allow Orbit to be used in more space-constrained environments, like app clips.

Orbit target now builds in almost half the time (since some assets were moved to OrbitIllustrations): before after
original new

This does affect snapshots, unfortunately - there is a new pink placeholder for illustrations, since the illustrations themselves are not availabie directly in Orbit anymore.

During implementation, I discovered that using bundle: .module works for the illustrations target. It seems like the original problem described in Bundle.swift (https://forums.swift.org/t/swift-package-with-resources-in-ios-project-wont-compile-test-targets/40846) has actually been fixed, so we should be able to now delete that file.

Closes #329