Open silvenon opened 3 years ago
Hi, I think I can help you with this!
That would be very much appreciated! Let me know if you need any help 😉 The configs have most likely diverged significantly, so when in doubt, prefer the rules that are in eslintJS.js
.
Of course, assign this to me 👍
Hi @silvenon, I'm currently working on this, but I am a little bit confused, the issue description says that there's 'a lot of repetition' in both files, but I don't see it. Maybe I did not get the main idea. Can you help me?
That's true, it's kinda standalone currently, but try applying to it everything that isn't specifically Flow-related so we see what happens. When we start adding TypeScript files at some point in the future, we want to have the same ESLint support as we did for Flow files.
Currently our ESLint config for JavaScript (Flow) and TypeScript are strictly separated, but when we start adding TypeScript files at some point in the future, we want to have the same ESLint support as we did for Flow files. We should extract the common parts of the configuration and
eslintJS.js
andeslintTS.js
should strictly contain config related to Flow and TypeScript respectively, while everything else should be ineslintCommon.js
that both would extend.