Closed sarkaaa closed 2 months ago
Storybook staging is available at https://kiwicom-orbit-sarka-fix-alert-button-overflow.surge.sh
Size Change: +27 B (+0.01%)
Total Size: 445 kB
Filename | Size | Change |
---|---|---|
packages/orbit-components/lib/Alert/index.js |
1.63 kB | +28 B (+1.74%) |
packages/orbit-components/lib/icons/ColoredImessage.js |
693 B | -2 B (-0.29%) |
packages/orbit-components/lib/icons/ColoredTelegram.js |
821 B | +1 B (+0.12%) |
Latest commit: |
d199948
|
Status: | ✅ Deploy successful! |
Preview URL: | https://7c667b7a.orbit.pages.dev |
Branch Preview URL: | https://sarka-fix-alert-button-overf.orbit.pages.dev |
I was also thinking about extending this PR by adding visual tests? I've checked respective ct-story
file and it looks it covers only AlertButton
component. WDYT? 🤔
Before:
Now:
This is not expected. Both the icon and the close button need to stay on top, aligned with the first line of the title (I know the close button was not, so we can either leave in the same position as it was or fix that here)
I have fixed the position of icon & cancel button.
For inlineAlert
:
WDYT?
(before - master branch):
Additional note: I have found that the button is shrinked when the title/text is multiline. I'll include the fix in this MR as well.
This Pull Request meets the following criteria:
For new components:
d.ts
files and are exported inindex.d.ts
Closes https://kiwicom.atlassian.net/browse/FEPLT-2068