Closed sarkaaa closed 1 month ago
Storybook staging is available at https://kiwicom-orbit-sarka-storybook-migration-b4.surge.sh
Size Change: -4 B (0%)
Total Size: 461 kB
Filename | Size | Change |
---|---|---|
packages/orbit-components/lib/icons/ColoredImessage.js |
693 B | -1 B (-0.14%) |
packages/orbit-components/lib/icons/ColoredMessenger.js |
786 B | -2 B (-0.25%) |
packages/orbit-components/lib/icons/ColoredTelegram.js |
820 B | -1 B (-0.12%) |
ok, so I updated most of the stories (except Loading for now), I create 2nd commit for Modal, which I'll squash once it will be finalized.
In the modal:
WithForm
story to visualize example how modal and form can be used.With Itinerary
story to visualize an example of modal + itinerary (this story was in Itinerary before but it fits more for Modal
)ShortModal
, Sizes
as these functionalities can be simulated in the Playground
storyWithoutSections
story as it's almost same as RemovableSections
storyAlmost everything should be fixed, except the text
prop for Loading - additional note for this comment.
From my research, the previous SB included custom loadingText
arg (type string), which was passed to text
prop of Loading component. It seems that's the reason why it was accepted in older Storybook. You can check it here (loadingText
arg in controls), the file is here.
I think we have these options:
loadingText
as it is in the older version of Storybook.<Text>
component in the code as it's the current PR's version (and have text
control excluded from controls).text
in controls as a string, but it seems that "
would be needed.I like the most the second option (as it's now) because we don't mix loadingText
custom arg there, which can be confusing for the user. I don't like the third option.
What's your opinion? @domihustinova
UPDATE
regarding enum PALETTE
colors, I deleted it and replaced argType by
options: Object.keys(defaultTheme.orbit),
going this way we avoid the issue related to maintaining the enum when the palette color name list is updated
Regarding the Loading
, have you tried restricting the type of text
prop inside argTypes
to be type text
? I think it might help with the "
🤔
This Pull Request meets the following criteria:
For new components:
d.ts
files and are exported inindex.d.ts
Closes https://kiwicom.atlassian.net/browse/FEPLT-2075