Open sarkaaa opened 2 weeks ago
Storybook staging is available at https://kiwicom-orbit-sarka-tooltip-checkmark-icon-fix.surge.sh
Size Change: +2 B (0%)
Total Size: 461 kB
Filename | Size | Change |
---|---|---|
packages/orbit-components/lib/Checkbox/index.js |
1.22 kB | +3 B (+0.25%) |
packages/orbit-components/lib/icons/ColoredMessenger.js |
786 B | -1 B (-0.13%) |
Latest commit: |
e6fb476
|
Status: | ✅ Deploy successful! |
Preview URL: | https://853abd6f.orbit.pages.dev |
Branch Preview URL: | https://sarka-tooltip-checkmark-icon.orbit.pages.dev |
Have you consider adding this scenario to visual tests?
Edit: Your commit message has scope Checkbox
but you are changing TooltipPrimitive
. And I would maybe change the message to something like "ensure Check icon is visible for checked state", WDYT?
Have you consider adding this scenario to visual tests?
actually, that's a good point! I'll cover it, thx.
As we discussed during the day, I've added tests for various types of checkboxes + tooltip (disabled
, checked
, hasError
, readOnly
) to cover as much as possible.
cc @domihustinova
it took some time, but in the end, I replaced browserName
condition with viewport.width
. With that, we can distinguish small/medium mobile and largeMobile/tablet, which have different type of a tooltip component.
I added assertion to check the visibility of tooltip to be sure that screenshot is not done before tooltip is loaded and shown:
await expect(tooltip).toBeVisible();
checkbox with checked & disabled state is also covered. ✅
This Pull Request meets the following criteria:
For new components:
d.ts
files and are exported inindex.d.ts
Closes https://kiwicom.atlassian.net/browse/FEPLT-2097