search

kiwicom / pytest-recording

A pytest plugin that allows recording network interactions via VCR.py
MIT License
425 stars 34 forks source link

Don't add YAML extension to JSON cassettes #10

Closed dmfigol closed 5 years ago

dmfigol commented 5 years ago

Thank you for the plugin. Unfortunately, it is really hard to find it as pytest-vcr always comes first in the search.

I have the following issue: If I use serializer="json" and I use something like @pytest.mark.vcr('list_rooms.json'), then the plugin adds yaml extension to the cassette (list_rooms.json.yaml), though it is saved as json correctly.

Stranger6667 commented 5 years ago

Hello @dmfigol :) Thank you for reporting the issue :) I will take a look tomorrow

Stranger6667 commented 5 years ago

Fixed in 0.3.2 release (already on PyPI). Feel free to reopen the issue if the problem occurs again :)