kiwicom / pytest-recording

A pytest plugin that allows recording network interactions via VCR.py
MIT License
425 stars 34 forks source link

Support VCR.py >=5 (fixes #111) #118

Closed hartwork closed 1 year ago

hartwork commented 1 year ago

Description

Partial pull request for support for VCR.py >=5 as offered at https://github.com/kiwicom/pytest-recording/issues/111#issuecomment-1651595271 . I lack the bandwidth to re-write the two tests marked as "todo" at the moment, but I should find time for smaller adjustments/additions that come up during review. Thanks for your understanding.

Checklist

Fixes #111

CC @Stranger6667

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c03c184) 100.00% compared to head (06cc9db) 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #118 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 8 8 Lines 283 287 +4 Branches 54 54 ========================================= + Hits 283 287 +4 ``` | [Files Changed](https://app.codecov.io/gh/kiwicom/pytest-recording/pull/118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kiwicom) | Coverage Δ | | |---|---|---| | [src/pytest\_recording/\_vcr.py](https://app.codecov.io/gh/kiwicom/pytest-recording/pull/118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kiwicom#diff-c3JjL3B5dGVzdF9yZWNvcmRpbmcvX3Zjci5weQ==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Stranger6667 commented 1 year ago

Awesome! Thanks!