Disallow multiple `network.block()` calls - Githubissues

kiwicom / pytest-recording

A pytest plugin that allows recording network interactions via VCR.py

MIT License

425 stars 34 forks source link

Disallow multiple `network.block()` calls #43

Open Stranger6667 opened 4 years ago

Stranger6667 commented 4 years ago

If the --block-network CMD option is passed, and if network.block is called in code, then one will overwrite another, and it depends on the execution order, which may lead to hard-to-track bugs in tests (it happened in one of our projects)

Implementation notes:

In the network.block call check if socket.socket.connect is already replaced
If so, raise a RuntimeError with some explanation