search

kiwicom / pytest-recording

A pytest plugin that allows recording network interactions via VCR.py
MIT License
425 stars 34 forks source link

chore: Validate input arguments for `vcr` and `block_network` pytest marks #70

Closed Stranger6667 closed 3 years ago

Stranger6667 commented 3 years ago

Resolves #69

codecov-commenter commented 3 years ago

Codecov Report

Merging #70 (718f513) into master (e0ae83d) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head 718f513 differs from pull request most recent head 26aa355. Consider uploading reports for the commit 26aa355 to get more accurate results Impacted file tree graph

@@            Coverage Diff            @@
##            master       #70   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         7    +1     
  Lines          261       269    +8     
  Branches        34        36    +2     
=========================================
+ Hits           261       269    +8
Flag Coverage Δ
unittests 99.62% <100.00%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pytest_recording/plugin.py 100.00% <100.00%> (ø)
src/pytest_recording/validation.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e0ae83d...26aa355. Read the comment docs.

Stranger6667 commented 3 years ago

It would be better to have config validation on the VCR-py level itself, as it is quite unreliable to provide the validation here.