Add boarding pass info - Githubissues

kiwicom / smart-faq

Smart FAQ ⚠️INACTIVE → moved to internal GitLab ⚠️

https://kiwicom.github.io/smart-faq/

MIT License

11 stars 7 forks source link

Add boarding pass info #454

Closed jaroslav-kubicek closed 6 years ago

jaroslav-kubicek commented 6 years ago

Acceptance criteria

[x] When clicking on the boarding pass, specific FAQ category is shown
[x] Info about the availability of boarding pass is shown
[ ] Show tooltip for boarding pass at the airport https://zpl.io/25qwg9J

Note GraphQL server will need to be updated to provide such info.

Zeplin: https://zpl.io/beYLgOP

MRTNKCR commented 6 years ago

Is there any ETA for this issue please? What is missing to have it complete? Thank you.

kantord commented 6 years ago

Today I've been working to have a PR on graphql merged that can simplify it. I hope to meet the acceptance criteria today, so as stated in my standup it might be finished today. I'd like to spend some time refactoring this as there is a lot of code duplication introduced here, but that might be done in a separate issue so that this can go through QA in the meantime

MRTNKCR commented 6 years ago

Thanks, that sounds good. I would be great to have this pushed through to QA and prod this week, we can focus on the improvements later.

kantord commented 6 years ago

Well, it might not pass the code review with this much code duplication. (If there will be anyone available to review it, that is :smile: )

kantord commented 6 years ago

The graphql stuff I did were merged, so I pushed a new commit that displays the flights and their boarding passes.

Notes:

the data about availability in terms of time left/free pickup at airport is not even in graphql yet. This might not be trivial
to my best knowledge, we don't even have a tooltip component yet, so that will have to be implemented too

So even though the list is working and boarding passes can be downloaded, implementing all the details on the designs perfectly might take more time.

MagdalenaAlmanova commented 6 years ago

I found some bugs:

The text "boarding pass" should be better centralized on the icon of the boarding pass, I think... Demo v. Prototype v.
The text "Here, you can download your ...." should be divided and I am not sure but shouldn't be there a dot? In the "baggage" there is one and in the "boarding pass" isn't? demo v. Prototype v.
Destinations aren't bold in Opera and Chrome (last v.)
The same problem as in the "baggage" issue. When I click on "baggage" or "boarding pass" it shows me baggage or boarding passes, but when I "unclicked" "baggage" or "boarding pass" it shows me nothing. I think that it should show FAQ categories.

MRTNKCR commented 6 years ago

@mjancik what should happen when the user "unclicks" the button?

mjancik commented 6 years ago

The BP/Baggage buttons are orbit link buttons. (except that they stay "focused")
Yes there should be a full stop after the description.
After un-clicking it should return to home screen. (FAQ categories with search on the right)

kantord commented 6 years ago

@mjancik thanks for the info. One more: what should happen if the user navigates away from the category but doesn't un-click the baggage/boarding pass button?

mjancik commented 6 years ago

Also un-focus the button :)

kantord commented 6 years ago

It seems that it's not possible to force an orbit button to stay "pressed". So we might have to stick with the custom implementation for now. Is that OK for the MVP?

mjancik commented 6 years ago

I was afraid of that. Yes, we can leave it custom. Until either I or Orbit guys can come up with a solution.

MagdalenaAlmanova commented 6 years ago

👍