Backstage alpha 20 master

[lgtm-com[bot]]

This pull request introduces 15 alerts and fixes 20 when merging 1ac1458990d8243712698bced8223aa4d9f16d42 into 0096d10b8e9d1f9f5beb1325276c05edd540a467 - view on LGTM.com

new alerts:

• 8 for Unused import
• 3 for Incomplete string escaping or encoding
• 2 for Unused variable, import, function or class
• 1 for Overwritten property
• 1 for Unneeded defensive code

fixed alerts:

• 11 for Unused variable, import, function or class
• 4 for Conflicting attributes in base classes
• 3 for Missing variable declaration
• 2 for Module is imported with 'import' and 'import from'

[lgtm-com[bot]]

This pull request introduces 15 alerts and fixes 20 when merging 6f535bca49c5d62e06db3dd42e90dd0011d0fd81 into 0096d10b8e9d1f9f5beb1325276c05edd540a467 - view on LGTM.com

new alerts:

• 8 for Unused import
• 3 for Incomplete string escaping or encoding
• 2 for Unused variable, import, function or class
• 1 for Overwritten property
• 1 for Unneeded defensive code

fixed alerts:

• 11 for Unused variable, import, function or class
• 4 for Conflicting attributes in base classes
• 3 for Missing variable declaration
• 2 for Module is imported with 'import' and 'import from'

[lgtm-com[bot]]

This pull request introduces 15 alerts and fixes 20 when merging bfa39775c2bbf5c218d03df890d98f207e080d6b into 0096d10b8e9d1f9f5beb1325276c05edd540a467 - view on LGTM.com

new alerts:

• 8 for Unused import
• 3 for Incomplete string escaping or encoding
• 2 for Unused variable, import, function or class
• 1 for Overwritten property
• 1 for Unneeded defensive code

fixed alerts:

• 11 for Unused variable, import, function or class
• 4 for Conflicting attributes in base classes
• 3 for Missing variable declaration
• 2 for Module is imported with 'import' and 'import from'

[ghost]

DeepCode's analysis on #3629de found:

• :x: 1 critical issue, :warning: 14 warnings, :information_source: 10 minor issues. :point_down:

  Top issues

Description	Example fixes
Unsanitized input flows from the request URL and is used to render an HTML page returned to the user in send. This may result in a Cross-Site Scripting attack (XSS). Occurrences: sentry-api.ts:39 router.ts:35 OAuthProvider.ts:277	:wrench: Example fixes
The function defined here takes 1 parameter(s), but is called here with 3 argument(s). The extra arguments will be ignored. Occurrences: GridBlockWithButton.js:42 GridBlockWithButton.js:46	:wrench: Example fixes
The property highlight was previously set at highlight. Occurrences: siteConfig.js:87	:wrench: Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

[sourcery-ai[bot]]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 4.11%.

Quality metrics	Before	After	Change
Complexity	0.96 ⭐	0.55 ⭐	-0.41 👍
Method Length	50.30 ⭐	52.34 ⭐	2.04 👎
Working memory	7.02 🙂	5.50 ⭐	-1.52 👍
Quality	84.57% ⭐	88.68% ⭐	4.11% 👍

Other metrics	Before	After	Change
Lines	2581	681	-1900

Changed files	Quality Before	Quality After	Quality Change
zoo/api/query.py	75.76% ⭐	85.25% ⭐	9.49% 👍
zoo/api/types.py	91.50% ⭐	91.84% ⭐	0.34% 👍
zoo/auditing/admin.py	98.33% ⭐	98.83% ⭐	0.50% 👍
zoo/base/settings.py	30.98% 😞	30.83% 😞	-0.15% 👎
zoo/base/urls.py	44.88% 😞	63.21% 🙂	18.33% 👍
zoo/base/management/commands/fake.py	90.58% ⭐	89.56% ⭐	-1.02% 👎
zoo/datacenters/models.py	90.52% ⭐	88.83% ⭐	-1.69% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
zoo/api/types.py	Dependency.resolve_all_dependency_usages	1 ⭐	92 🙂	10 😞	69.12% 🙂	Extract out complex expressions
zoo/api/types.py	Service.from_db	0	40 ⭐	11 😞	76.21% ⭐	Extract out complex expressions
zoo/api/types.py	ActiveIncident.from_object	1 ⭐	36 ⭐	10 😞	77.76% ⭐	Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

[lgtm-com[bot]]

This pull request introduces 9 alerts and fixes 20 when merging 3629dec649dd8c714634e2b7b2b420c546b16b34 into 748cb9adc52082ec9bacd9c8554bdffe9199e2fc - view on LGTM.com

new alerts:

• 3 for Incomplete string escaping or encoding
• 2 for Unused import
• 2 for Unused variable, import, function or class
• 1 for Overwritten property
• 1 for Unneeded defensive code

fixed alerts:

• 11 for Unused variable, import, function or class
• 4 for Conflicting attributes in base classes
• 3 for Missing variable declaration
• 2 for Module is imported with 'import' and 'import from'