Closed gjuro87 closed 3 years ago
This pull request introduces 2 alerts when merging 730434528f1ef36f66a6b57b56658ca7fc107986 into e6941b17b46d78f8fb219b7ddc4f20141653a1bb - view on LGTM.com
new alerts:
This pull request introduces 1 alert when merging ad11f00f4a768ef6954e99988032e75a508c6f72 into e6941b17b46d78f8fb219b7ddc4f20141653a1bb - view on LGTM.com
new alerts:
Description | Example fixes |
---|---|
Array type using 'Array |
:wrench: Example fixes |
Type declaration of 'any' loses type-safety. Consider replacing it with a more precise type. Occurrences: | :wrench: Example fixes |
β Merging this PR will decrease code quality in the affected files by 0.34%.
Quality metrics | Before | After | Change |
---|---|---|---|
Complexity | 0.54 β | 0.50 β | -0.04 π |
Method Length | 33.77 β | 35.11 β | 1.34 π |
Working memory | 7.21 π | 7.53 π | 0.32 π |
Quality | 81.77% β | 81.43% β | -0.34% π |
Other metrics | Before | After | Change |
---|---|---|---|
Lines | 253 | 282 | 29 |
Changed files | Quality Before | Quality After | Quality Change |
---|---|---|---|
zoo/api/types.py | 81.77% β | 81.43% β | -0.34% π |
Here are some functions in these files that still need a tune-up:
File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
---|---|---|---|---|---|---|
zoo/api/types.py | SentryIssue.resolve_histogram | 0 β | 89 π | 18 β | 59.69% π | Extract out complex expressions |
zoo/api/types.py | Dependency.resolve_all_dependency_usages | 1 β | 92 π | 11 π | 67.22% π | Extract out complex expressions |
zoo/api/types.py | PagerdutyInfo.resolve_all_active_incidents | 1 β | 75 π | 11 π | 69.70% π | Extract out complex expressions |
zoo/api/types.py | Service.resolve_all_environments | 1 β | 83 π | 10 π | 70.41% π | Extract out complex expressions |
zoo/api/types.py | Service.from_db | 0 β | 40 β | 12 π | 74.47% π | Extract out complex expressions |
The emojis denote the absolute quality of the code:
The π and π indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Let us know what you think of it by mentioning @sourcery-ai in a comment.
SonarCloud Quality Gate failed.
This pull request introduces 3 alerts when merging 4297b136351c9a6ed394e06192a60942060433d7 into e6941b17b46d78f8fb219b7ddc4f20141653a1bb - view on LGTM.com
new alerts: