kiwicom / the-zoo

πŸ’ A service registry for humans
MIT License
92 stars 6 forks source link

WIP: Jgrgicevic/sentry panel #351

Closed gjuro87 closed 3 years ago

lgtm-com[bot] commented 3 years ago

This pull request introduces 3 alerts when merging 4297b136351c9a6ed394e06192a60942060433d7 into e6941b17b46d78f8fb219b7ddc4f20141653a1bb - view on LGTM.com

new alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 2 alerts when merging 730434528f1ef36f66a6b57b56658ca7fc107986 into e6941b17b46d78f8fb219b7ddc4f20141653a1bb - view on LGTM.com

new alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert when merging ad11f00f4a768ef6954e99988032e75a508c6f72 into e6941b17b46d78f8fb219b7ddc4f20141653a1bb - view on LGTM.com

new alerts:

ghost commented 3 years ago

DeepCode's analysis on #5e443f found:

Description Example fixes
Array type using 'Array' is forbidden for simple types. Use 'T[]' instead. Occurrences: :wrench: Example fixes
Type declaration of 'any' loses type-safety. Consider replacing it with a more precise type. Occurrences: :wrench: Example fixes

πŸ‘‰ View analysis in DeepCode’s Dashboard | Configure the bot

sourcery-ai[bot] commented 3 years ago

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.34%.

Quality metrics Before After Change
Complexity 0.54 ⭐ 0.50 ⭐ -0.04 πŸ‘
Method Length 33.77 ⭐ 35.11 ⭐ 1.34 πŸ‘Ž
Working memory 7.21 πŸ™‚ 7.53 πŸ™‚ 0.32 πŸ‘Ž
Quality 81.77% ⭐ 81.43% ⭐ -0.34% πŸ‘Ž
Other metrics Before After Change
Lines 253 282 29
Changed files Quality Before Quality After Quality Change
zoo/api/types.py 81.77% ⭐ 81.43% ⭐ -0.34% πŸ‘Ž

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
zoo/api/types.py SentryIssue.resolve_histogram 0 ⭐ 89 πŸ™‚ 18 β›” 59.69% πŸ™‚ Extract out complex expressions
zoo/api/types.py Dependency.resolve_all_dependency_usages 1 ⭐ 92 πŸ™‚ 11 😞 67.22% πŸ™‚ Extract out complex expressions
zoo/api/types.py PagerdutyInfo.resolve_all_active_incidents 1 ⭐ 75 πŸ™‚ 11 😞 69.70% πŸ™‚ Extract out complex expressions
zoo/api/types.py Service.resolve_all_environments 1 ⭐ 83 πŸ™‚ 10 😞 70.41% πŸ™‚ Extract out complex expressions
zoo/api/types.py Service.from_db 0 ⭐ 40 ⭐ 12 😞 74.47% πŸ™‚ Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

The πŸ‘ and πŸ‘Ž indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

sonarcloud[bot] commented 3 years ago

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

55.0% 55.0% Coverage
0.0% 0.0% Duplication