Jgrgicevic/sw 727 resource list component

kiwicom / the-zoo

🐒 A service registry for humans

MIT License

93 stars 6 forks source link

Jgrgicevic/sw 727 resource list component #360

Closed gjuro87 closed 3 years ago

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert when merging 5fc93c769dc69651172ef5380c2dce8da60617f5 into 06bcd0d872557358745ef0cd3cff16b9f5bed5c0 - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

lgtm-com[bot] commented 3 years ago

This pull request introduces 2 alerts when merging 7a216da633ffcdba3cdf859a39c49944b868f56c into 4410c3b1bf3c7038f0d58243ea0ff9e7ac20672c - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

batisteo commented 3 years ago

The table search doesn’t pickup the name. I’m not sure how long would it be to fix it. Do you plan to add this feature in a later commit/MR?

gjuro87 commented 3 years ago

The table search doesn’t pickup the name. I’m not sure how long would it be to fix it. Do you plan to add this feature in a later commit/MR?

@batisteo you are right. It doesn't work because i have used components like chip component as a value of table and search is doing compare by value. In case of compoment is object so it doesn’t match it. I will look at source code of backstage table and create our own table that matches our needs.

gjuro87 commented 3 years ago

The table search doesn’t pickup the name. I’m not sure how long would it be to fix it. Do you plan to add this feature in a later commit/MR?

@batisteo you are right. It doesn't work because i have used components like chip component as a value of table and search is doing compare by value. In case of compoment is object so it doesn’t match it. I will look at source code of backstage table and create our own table that matches our needs.

@batisteo fixed :)

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert when merging 2a3933c35d74d77baf22d542979fa3b12ae03637 into 4410c3b1bf3c7038f0d58243ea0ff9e7ac20672c - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

batisteo commented 3 years ago

Great!

Could you address the DeepCode issues?

ghost commented 3 years ago

Congratulations :tada:. DeepCode analyzed your code in 5.957 seconds and we found no issues. Enjoy a moment of no bugs :sunny:.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert when merging 81bf2c68d7138f817d2445b05cbeeefb7c3e8f96 into 4410c3b1bf3c7038f0d58243ea0ff9e7ac20672c - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information