Closed gjuro87 closed 3 years ago
This pull request fixes 5 alerts when merging 0868fde2adc1df4d2bb4d1b376f1329136333416 into 8a83302f0903821f316cf7c4249defb11ac6f90c - view on LGTM.com
fixed alerts:
Bug fixed, thx for help
This pull request fixes 5 alerts when merging 0ba4e4468708d7b4854fb185b8e5c9a49b33a539 into 8a83302f0903821f316cf7c4249defb11ac6f90c - view on LGTM.com
fixed alerts:
For the Pytest check, run pytest test/api/query/test_node.py --snapshot-update
and review https://github.com/kiwicom/the-zoo/blob/hangar/test/api/query/snapshots/snap_test_node.py
This pull request fixes 5 alerts when merging e7c7cf0eacad8f3cdb3f58291c4213954210d1ab into 8a83302f0903821f316cf7c4249defb11ac6f90c - view on LGTM.com
fixed alerts:
This pull request fixes 5 alerts when merging 663e2f9b1cfcc4b85307461c66193f00d398db7e into 8a83302f0903821f316cf7c4249defb11ac6f90c - view on LGTM.com
fixed alerts:
Congratulations :tada:. DeepCode analyzed your code in 6.281 seconds and we found no issues. Enjoy a moment of no bugs :sunny:.
β Merging this PR will decrease code quality in the affected files by 0.97%.
Quality metrics | Before | After | Change |
---|---|---|---|
Complexity | 0.45 β | 0.38 β | -0.07 π |
Method Length | 35.63 β | 36.68 β | 1.05 π |
Working memory | 7.75 π | 7.78 π | 0.03 π |
Quality | 83.66% β | 82.69% β | -0.97% π |
Other metrics | Before | After | Change |
---|---|---|---|
Lines | 408 | 396 | -12 |
Changed files | Quality Before | Quality After | Quality Change |
---|---|---|---|
test/api/query/snapshots/snap_test_node.py | 46.29% π | 47.79% π | 1.50% π |
zoo/api/types.py | 85.16% β | 84.07% β | -1.09% π |
Here are some functions in these files that still need a tune-up:
File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
---|---|---|---|---|---|---|
zoo/api/types.py | SentryIssue.resolve_histogram | 0 β | 89 π | 18 β | 59.69% π | Extract out complex expressions |
zoo/api/types.py | Dependency.resolve_all_dependency_usages | 1 β | 92 π | 11 π | 67.22% π | Extract out complex expressions |
zoo/api/types.py | PagerdutyInfo.resolve_all_active_incidents | 1 β | 75 π | 11 π | 69.70% π | Extract out complex expressions |
zoo/api/types.py | Service.resolve_all_environments | 1 β | 83 π | 10 π | 70.41% π | Extract out complex expressions |
zoo/api/types.py | Service.from_db | 0 β | 40 β | 12 π | 74.47% π | Extract out complex expressions |
The emojis denote the absolute quality of the code:
The π and π indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Let us know what you think of it by mentioning @sourcery-ai in a comment.
This pull request fixes 5 alerts when merging 8df53cd2b48b78449c94cb56c05329e1cee2f3fb into 8a83302f0903821f316cf7c4249defb11ac6f90c - view on LGTM.com
fixed alerts:
Kudos, SonarCloud Quality Gate passed!
Everything is done. There is one issue that i solved in another way. Issue when calling dependency graphql query and requesting id. Result is error: "'Dependency' object has no attribute 'pk'". I couldn't find the cause. I have solve it another way, not requesting id, but needs to be solved. If you could take a look