kiwicom / the-zoo

🐒 A service registry for humans
MIT License
92 stars 6 forks source link

feat(repos): index openapi endpoints (Sourcery refactored) #387

Closed sourcery-ai[bot] closed 3 years ago

sourcery-ai[bot] commented 3 years ago

Pull Request #386 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will re-run and update (force-push) this Pull Request with new refactorings as necessary. If Sourcery finds no refactorings at any point, this Pull Request will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the aexvir/openapi-endpoint-index branch, then run:

git fetch origin sourcery/aexvir/openapi-endpoint-index
git merge --ff-only FETCH_HEAD
git reset HEAD^
sourcery-ai[bot] commented 3 years ago

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.32%.

Quality metrics Before After Change
Complexity 6.60 ⭐ 6.62 ⭐ 0.02 👎
Method Length 49.86 ⭐ 49.29 ⭐ -0.57 👍
Working memory 9.70 🙂 9.51 🙂 -0.19 👍
Quality 68.72% 🙂 69.04% 🙂 0.32% 👍
Other metrics Before After Change
Lines 114 111 -3
Changed files Quality Before Quality After Quality Change
zoo/analytics/tasks/requirements_py.py 68.72% 🙂 69.04% 🙂 0.32% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
zoo/analytics/tasks/requirements_py.py get_unhealthy_packages 9 🙂 93 🙂 12 😞 57.56% 🙂 Extract out complex expressions
zoo/analytics/tasks/requirements_py.py is_package_unhealthy 3 ⭐ 52 ⭐ 12 😞 69.55% 🙂 Extract out complex expressions
zoo/analytics/tasks/requirements_py.py analyze 5 ⭐ 50 ⭐ 11 😞 69.63% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

aexvir commented 3 years ago

it's not code I modified on my changes... I'd rather not merge this now