kiwicom / the-zoo

🐒 A service registry for humans
MIT License
92 stars 6 forks source link

fix(repos): keep tmp dir during the checks run #390

Closed jarosevcik closed 3 years ago

aexvir commented 3 years ago

first of all... can you please add tests? 🙏️

sourcery-ai[bot] commented 3 years ago

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.90%.

Quality metrics Before After Change
Complexity 0.85 ⭐ 0.65 ⭐ -0.20 👍
Method Length 64.00 🙂 66.64 🙂 2.64 👎
Working memory 10.13 😞 9.93 😞 -0.20 👍
Quality 71.19% 🙂 70.29% 🙂 -0.90% 👎
Other metrics Before After Change
Lines 158 193 35
Changed files Quality Before Quality After Quality Change
test/repos/test_utils.py 70.68% 🙂 69.50% 🙂 -1.18% 👎
zoo/repos/utils.py 71.80% 🙂 71.80% 🙂 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
zoo/repos/utils.py download_repository 3 ⭐ 107 🙂 11 😞 63.17% 🙂 Extract out complex expressions
test/repos/test_utils.py test_download_repository__missing_files.test_download_repository.test_download_repository__custom_sha.test_openapi_definition 0 ⭐ 144 😞 10 😞 63.57% 🙂 Try splitting into smaller methods. Extract out complex expressions
test/repos/test_utils.py test_download_repository__missing_files.test_download_repository.test_download_repository__custom_sha 0 ⭐ 97 🙂 13 😞 64.22% 🙂 Extract out complex expressions
test/repos/test_utils.py test_download_repository__missing_files.test_download_repository 0 ⭐ 93 🙂 12 😞 66.35% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

81.2% 81.2% Coverage
0.0% 0.0% Duplication

ghost commented 3 years ago

DeepCode failed to analyze this pull request

Something went wrong despite trying multiple times, sorry about that. Please comment this pull request with "Retry DeepCode" to manually retry, or contact us so that a human can look into the issue.